GafferUI : Fix local documentation links on Windows - #7134
Open
pascalandr wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @pascalandr, I see from tag on the PR this is your first Gaffer contribution, welcome! I'm curious about the reproduction steps that led to broken documentation links. All of the help links are working fine for me using Gaffer 1.7.1.0, Windows 11 and either Firefox or Microsoft Edge. Is there another configuration where the links are not working? |
Author
|
Hi @ericmehl , thanks for checking. I tracked this down to spaces in the installation path. With stock Gaffer 1.7.1.0 on Windows 11:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes local documentation links such as Help > User Guide and Help > Node Reference on Windows.
showURL()currently strips thefile://prefix and passes the resulting drive-letter path toQUrl. Qt interprets the drive letter as the URL scheme (c:), soQDesktopServicesdoes not open the local HTML file. This change usesQUrl.fromLocalFile()for that Windows-specific branch.Related issues
Dependencies
Breaking changes
Checklist
Testing
Validated with the Qt bindings shipped in Gaffer 1.7.1.0 on Windows. The resulting URL uses the
filescheme, reportsisLocalFile() == True, preserves paths containing spaces, and strips the unsupported fragment. HTTPS URL handling is unchanged.The full repository test suite was not run because this checkout has no compiled build; the targeted behavior and Python syntax were tested against the installed Gaffer 1.7.1.0 runtime.